[Libvirt-ci] Still Failing: libvirt/libvirt#2885 (master - 9d6920b)

[Travis CI]

Build Update for libvirt/libvirt
-------------------------------------

Build: #2885
Status: Still Failing

Duration: 41 mins and 18 secs
Commit: 9d6920b (master)
Author: Laine Stump
Message: net/qemu: move vlan/bandwidth validation out of network driver

In the past the network driver was (mistakenly) being called for all
interfaces, not just those of type='network', and so it had a chance
to validate all interface configs after the actual type of the
interface was known.

But since the network driver has been more completely/properly
separated from qemu, the network driver isn't called during the
startup of any interfaces except those with type='network', so this
validation no longer takes place for, e.g. <interface type='bridge'>
(or direct, etc). This in turn meant that a config could erroneously
specify a vlan tag, or bandwidth settings, for a type of interface
that didn't support it, and the domain would start without complaint,
just silently ignoring those settings.

This patch moves those validation checks out of the network driver,
and into virDomainActualNetDefValidate() so they will be done for all
interfaces, not just type='network'.

https://bugzilla.redhat.com/1741121
Signed-off-by: Laine Stump <laine at redhat.com>
Reviewed-by: Cole Robinson <crobinso at redhat.com>

View the changeset: https://github.com/libvirt/libvirt/compare/9b1d53d4170c...9d6920bd7de3

View the full build log and details: https://travis-ci.org/libvirt/libvirt/builds/616877000?utm_medium=notification&utm_source=email

--

You can unsubscribe from build emails from the libvirt/libvirt repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=4872032&utm_medium=notification&utm_source=email.
Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification&utm_source=email.
Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvirt-ci/attachments/20191125/feae6ad4/attachment.htm>