[Libvirt-ci] Still Failing: libvirt/libvirt#2787 (master - 3b4df5d)

[Travis CI]

Build Update for libvirt/libvirt
-------------------------------------

Build: #2787
Status: Still Failing

Duration: 23 mins and 17 secs
Commit: 3b4df5d (master)
Author: Michal Privoznik
Message: Drop needless ret variable

In few places we have the following code pattern:

  int ret;
  ... /* @ret is not accessed here */
  ret = f(...);
  return ret;

This pattern can be written less verbose:

  ...
  return f(...);

This patch was generated with following coccinelle spatch:

  @@
  type T;
  constant C;
  expression f;
  identifier ret;
  @@
  -T ret = C;
   ... when != ret
  -ret = f;
  -return ret;
  +return f;

Afterwards I needed to fix a few places, e.g. comment in
virDomainNetIPParseXML() was removed too because coccinelle
thinks it refers to @ret while in fact it doesn't. Also in few
places it replaced @ret declaration with a few spaces instead of
removing the line. But nothing terribly wrong.

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
Reviewed-by: Daniel Henrique Barboza <danielhb413 at gmail.com>

View the changeset: https://github.com/libvirt/libvirt/compare/b3739aa63f89...3b4df5d350d8

View the full build log and details: https://travis-ci.org/libvirt/libvirt/builds/602171350?utm_medium=notification&utm_source=email

--

You can unsubscribe from build emails from the libvirt/libvirt repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=4872032&utm_medium=notification&utm_source=email.
Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification&utm_source=email.
Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvirt-ci/attachments/20191024/aaf9dd52/attachment.htm>