New Defects reported by Coverity Scan for libvirt

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to libvirt found with Coverity Scan.

2 new defect(s) introduced to libvirt found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 314770:  Memory - corruptions  (USE_AFTER_FREE)


________________________________________________________________________________________________________
*** CID 314770:  Memory - corruptions  (USE_AFTER_FREE)
/src/qemu/qemu_extdevice.c: 138 in qemuExtDevicesPrepareHost()
132         virDomainDefPtr def = vm->def;
133         size_t i;
134     
135         if (qemuExtDevicesInitPaths(driver, def) < 0)
136             return -1;
137     
>>>     CID 314770:  Memory - corruptions  (USE_AFTER_FREE)
>>>     Calling "qemuExtTPMPrepareHost" frees pointer "driver->config" which has already been freed.
138         if (def->ntpms > 0 &&
139             qemuExtTPMPrepareHost(driver, def) < 0)
140             return -1;
141     
142         for (i = 0; i < def->nnets; i++) {
143             virDomainNetDefPtr net = def->nets[i];

** CID 314769:  Null pointer dereferences  (FORWARD_NULL)
/src/util/virfirewall.c: 769 in virFirewallApply()


________________________________________________________________________________________________________
*** CID 314769:  Null pointer dereferences  (FORWARD_NULL)
/src/util/virfirewall.c: 769 in virFirewallApply()
763              */
764             virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
765                            _("Failed to initialize a valid firewall backend"));
766             goto cleanup;
767         }
768         if (!firewall || firewall->err) {
>>>     CID 314769:  Null pointer dereferences  (FORWARD_NULL)
>>>     Dereferencing null pointer "firewall".
769             virReportSystemError(firewall->err, "%s",
770                                  _("Unable to create rule"));
771             goto cleanup;
772         }
773     
774         VIR_DEBUG("Applying groups for %p", firewall);


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yqXyKjvBooc6PgQklkMPQjdETL0zD-2BwwS2MT3CUz0PGk4uLnDSo8-2B2mZ3lSeSytwjA-3DWiEz_CkO38-2FnXVYPAlDbR1ZxdHNqvqoSWeUuqu9763V-2FVMwyyEfI-2B-2Fadc8ntiTjG17I8o-2FH7rmFIFdlqNNMOQRrh0pRNexrxhDz7vYMYEsG7Cr5Iq7gX30YlsCKV7iyr7U7CAlMRfoQWOjJCoqKDz9Y-2Ff8CKem4GRGcAJVQ-2BumvujNJZf6x5wjztYjhCBXF1rChLYaSpT2goMQ4iKM0Yo9VumuIj74YHLJf01154zzFOpS0k-3D