[Libvirt-cim] [PATCH] Patch guidelines added to SubmittingPatches

Jay Gagnon grendel at linux.vnet.ibm.com
Mon Dec 3 17:01:13 UTC 2007


Daniel Veillard wrote:
> On Mon, Dec 03, 2007 at 11:44:41AM -0500, Jay Gagnon wrote:
>   
>> Dan Smith wrote:
>>     
>>> JG> I wouldn't mind adding a page to the site, especially since then I
>>> JG> could use some nice formatting to make it a little easier to read.
>>> JG> I'm unfamiliar with this xsl thing though, so a primer on that
>>> JG> would be appreciated.
>>>
>>> If you look at the top of the site.xsl, you see all the external pages
>>> that will be generated.  Adding something like this would be your
>>> first step.
>>>
>>>   <xsl:when test="$name = '#Patches'">
>>>     <xsl:text>patches.html</xsl:text>
>>>   </xsl:when>
>>>
>>> Then, in the libvirt-cim.html, add a new <h2><a name="Patches"> and
>>> the content between that and the next <h2> (or EOF) will go into
>>> patches.html.  Just run "make" in doc/ to regenerate it each time you
>>> tweak it.
>>>
>>>   
>>>       
>> Just curious, in site.xsl, why do some of the test conditions have
>> truncated names?  For example:
>>
>>       <xsl:when test="$name = '#Documentat'">
>>         <xsl:text>docs.html</xsl:text>
>>       </xsl:when>
>>
>> It seems that anytime $name would end in "ion" it gets the "ion" or the
>> "on" part at the end cut off.
>>     
>
>   Haha, it's the magic of reuse (Dan started of will libvirt html I think)
> and the fact that i used Amaya a long time ago to edit such files, and
> it was generating the IDs that way. Really no big deal or significance,
>
>   

Oh okay.  I was hoping it was something like that, really.  I was
slightly worried about what the possible explanations could be. :)

-- 

-Jay




More information about the Libvirt-cim mailing list