[Libvirt-cim] [PATCH 3 of 6] Add VirtualSystemMigrationService

[Kaitlin Rupert]

Dan Smith wrote:
> KR> I think to mean:
> KR>     if (dconn == NULL)
>
> I think to mean that too :)
>   
Excellent typo on my part ;)
> KR> I'm unsure why you call CMSetStatus() before calling
> KR> virDomainMigrate().  If virDomainMigrate() fails, we set a failure
> KR> status.  Otherwise, we set the status again below.  Although,
> KR> setting it here is harmless anyway. =)
>
> Heh, oops.  The reason is that when I was first working on it, the
> whole migrate function was just setting status to OK, which I
> apparently never removed.
>
> I've got a new version of this cooked up with more function anyway,
> I'll make these changes and send it out tomorrow.
>
> Thanks :)
>   
Could you also include instructions on testing migration?   It seems 
difficult to do via wbemcli - I haven't tested a method provider before.

-- 
Kaitlin Rupert
IBM Linux Technology Center
karupert at us.ibm.com