[Libvirt-cim] [PATCH] [RFC] #2 - variable renaming in make_ref() of associations

[Heidi Eckhart]

Dan Smith wrote:
> HE> +        CMPIInstance *ref_inst = NULL;
> HE> +
> HE> +        ref_inst = make_reference(_BROKER, 
> HE> +                                  source_ref, 
> HE> +                                  target_inst,
> HE> +                                  assoc, 
> HE> +                                  "ElementAllocatedFromPool");
> HE> +
> HE> +        return ref_inst;
> HE>  }
>
> Why not just pass the make_reference function from libxkutil directly
> in the std_assoc block?  The function should be able to infer the name
> of the reference from the assoc_class field of the std_assoc or info
> struct, right?
>
> That would let us cut out even more code from all the providers :)
That's a ery interesting idea ! Sadly the current input parameter list 
of make_ref_t() in struct std_assoc does not include a broker pointer, 
which prevents me from reworking it in your suggested way. Maybe you 
have an idea how to solve this ? Thanks :).

-- 
Regards

Heidi Eckhart
Software Engineer
Linux Technology Center - Open Hypervisor

heidieck at linux.vnet.ibm.com

**************************************************
IBM Deutschland Entwicklung GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter
Geschaeftsfuehrung: Herbert Kircher
Sitz der Gesellschaft: Boeblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294