[Libvirt-cim] [PATCH] [CU] Merge do_ref() and do_assoc()

[Heidi Eckhart]

Dan Smith wrote:
> Adding these additional clauses to do_assoc() makes the function too
> long and confusing, IMHO.  It was already rather long after recent
> additions.  Lets take this opportunity to refine it a bit.
>
> I think that we should be able to boil down the (ref_rslt == NULL) and
> (ref_rslt != NULL) cases into two small helper functions.  Each should
> build a result list.
> [...]
> This would then clear up this (IMHO, very confusing) case where you
> first have a associators case, then an "if references, else
> associators" case right behind it.
>
> Thoughts?
>   
Thank you for your feedback. I will rework the patch as suggested 
(hopefully got it ;) ) and send out the patch.
Thanks ... Heidi

-- 
Regards

Heidi Eckhart
Software Engineer
Linux Technology Center - Open Hypervisor

heidieck at linux.vnet.ibm.com

**************************************************
IBM Deutschland Entwicklung GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter
Geschaeftsfuehrung: Herbert Kircher
Sitz der Gesellschaft: Boeblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294