[Libvirt-cim] [PATCH] [CU] Merge do_ref() and do_assoc()

Kaitlin Rupert kaitlin at linux.vnet.ibm.com
Thu Dec 13 16:08:39 UTC 2007


Jay Gagnon wrote:
> Heidi Eckhart wrote:
>   
>> # HG changeset patch
>> # User Heidi Eckhart <heidieck at linux.vnet.ibm.com>
>> # Date 1197540659 -3600
>> # Node ID 0b30c3a70c3aa076d8aac5a6cf63af06413b056c
>> # Parent  b5847180d00719ff39f2d451d4e79d4369952ad5
>> [CU] Merge do_ref() and do_assoc()
>>     
> Time for me to play PCO.  This is #2, correct?  And the changes since
> the original are limited to cleaning up the logic in the new function
> and breaking some stuff out into helper functions, as Dan suggested?  It
> looks much nicer this way.  Good patch codewise, sorry I've got to be a
> pain about the guidelines. :)
>
>   

Besides the patch compliance issues, my read through and quick testing 
looked good.  =)  +1

-- 
Kaitlin Rupert
IBM Linux Technology Center
karupert at us.ibm.com





More information about the Libvirt-cim mailing list