[Libvirt-cim] [PATCH 2 of 2] SDC: RASD to AllocationCapabilities should return NOT_SUPPORTED instead of OK

Heidi Eckhart heidieck at linux.vnet.ibm.com
Fri Dec 14 08:56:58 UTC 2007


Dan Smith wrote:
> HE> -        CMPIStatus s = {CMPI_RC_OK};
> HE> -        
> HE> +        CMPIStatus s = {CMPI_RC_ERR_NOT_SUPPORTED};
> HE> +
> HE>          /* This direction of the association currently not supported. */
>          
> Not that it's a big deal or anything, but we do have
> RETURN_UNSUPPORTED() in libcmpiutil for this scenario.  
Sure, thanks for reminding me :). That's much better than setting the 
status by hand. Good catch. I will update the patch and resend with the 
changes of patch #1.
> If you like it
> and want to re-spin the patch with it, that would be cool.  Your
> call... :)
>
> Sorry I didn't get to reviewing this set until the second round...
Nop.

-- 
Regards

Heidi Eckhart
Software Engineer
Linux Technology Center - Open Hypervisor

heidieck at linux.vnet.ibm.com

**************************************************
IBM Deutschland Entwicklung GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter
Geschaeftsfuehrung: Herbert Kircher
Sitz der Gesellschaft: Boeblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294




More information about the Libvirt-cim mailing list