[Libvirt-cim] [PATCH 1 of 2] Fix VSMigrationService NULL key attributes

Dan Smith danms at us.ibm.com
Mon Dec 17 16:08:17 UTC 2007


KR> VirtualSystemMigrationSerive and VSMigrationService both need to
KR> get the values for these attributes in the same way.  It would be
KR> possible to lump this bit of code into a function in
KR> Virt_HostSystem, but it's unlikely that the implementation
KR> specific host provider will offer such a function (since
KR> Virt_HostSystem is acting as a placeholder).

My plan was never to remove the placeholder, but rather to modify the
placeholder with logic to look up and return the proper host system.
This would give us a control point for switching between host
instrumentation, with the option to keep our fake one if nothing else
is available.

Adding such a function seems like a good idea to me, and as long as it
uses the existing internal logic in HostSystem to get the information,
it shouldn't need to change later.

Shall I hold off on this set or apply and let you add the generalized
function first?

Thanks!

-- 
Dan Smith
IBM Linux Technology Center
Open Hypervisor Team
email: danms at us.ibm.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvirt-cim/attachments/20071217/c4222692/attachment.sig>


More information about the Libvirt-cim mailing list