[Libvirt-cim] [PATCH 3 of 3] AC no longer needs libVirt_RASD

Jay Gagnon grendel at linux.vnet.ibm.com
Mon Dec 17 16:21:39 UTC 2007


Kaitlin Rupert wrote:
> Kaitlin Rupert wrote:
>>  libVirt_VSMigrationCapabilities_la_SOURCES =
>> Virt_VSMigrationCapabilities.c
>>
>> -libVirt_VSMigrationService_la_SOURCES = Virt_VSMigrationService.c
>> \ No newline at end of file
>> +libVirt_VSMigrationService_la_SOURCES = Virt_VSMigrationService.c
>> +
>>
>>   
> I'm unsure why this showed up in the diff - I didn't make any changes
> to this line.  My apologies for the fuzz..
>
That kind of thing happens to me sometimes to, and it's very annoying
cuz it's an easy mistake to make.  It's entirely forgiveable though. 
It's officially on my (oh so secret) list of exceptions to the
guidelines, because it's such a stupid thing to have to look out for.  I
believe it is related to how emacs does certain operations, like "delete
the rest of this line" and that kind of thing.  Regardless, any time a
file with no newline at the end has one added, all nitpicking charges
will be dropped.  Removing the ending newline will not be overlooked,
however, because things will be cleaner if all files always have newline
at the end.  Hopefully that doesn't sound as arbitrary as it feels.

-- 

-Jay




More information about the Libvirt-cim mailing list