[Libvirt-cim] [PATCH 1 of 3] AC GetInstance() fails with a "Could not get ResourceType" error

Jay Gagnon grendel at linux.vnet.ibm.com
Mon Dec 17 17:06:46 UTC 2007


Dan Smith wrote:
> KR> Right, good point.  I didn't use "goto out" here because if we don't
> KR> encounter an error, we do the following:
>
> Actually, I think that's a good reason to just return from where you
> do.  I'm sure anything trying to allow the "goto out" will be ugly :)
>
>   
Well, I'd definitely rather have "slightly different than normal" over
"really ugly" here.  I didn't look too hard at the surrounding code, so
I didn't realize that it will get messy trying to use goto out.  No
worries, leave it as is.

-- 

-Jay




More information about the Libvirt-cim mailing list