[Libvirt-cim] [PATCH 2 of 2] SDC: returned instances are not of type specific subclass
Heidi Eckhart
heidieck at linux.vnet.ibm.com
Tue Dec 18 08:55:58 UTC 2007
Dan Smith wrote:
> HE> # HG changeset patch
> HE> # User Heidi Eckhart <heidieck at linux.vnet.ibm.com>
> HE> # Date 1197881325 -3600
> HE> # Node ID c22a61c0852055c920f46ffe82ab5761c7240444
> HE> # Parent 109fd77699732a1bc2969b93d9a799c446b3f4c0
> HE> SDC: returned instances are not of type specific subclass
>
> This looks better, thanks a lot for making that change. However, I
> just noticed something else:
>
> HE> - char *inst_id;
> HE> + char *inst_id = NULL;
>
> inst_id should be a const char * as well. Since we're touching it
> here, I think we might as well fix that up.
>
Good catch ! I will resend the patch set.
> Sorry to force another iteration, but if you wouldn't mind tweaking
> that one thing, I promise I'll commit this set without further
> complaint :P
>
:)
--
Regards
Heidi Eckhart
Software Engineer
Linux Technology Center - Open Hypervisor
heidieck at linux.vnet.ibm.com
**************************************************
IBM Deutschland Entwicklung GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter
Geschaeftsfuehrung: Herbert Kircher
Sitz der Gesellschaft: Boeblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
More information about the Libvirt-cim
mailing list