[Libvirt-cim] [PATCH] Fix externally-visible name of type_from_classname()

Dan Smith danms at us.ibm.com
Fri Nov 2 14:02:40 UTC 2007


HE> What is your intention by breaking this one-liner into three lines ?

Because when I went to make this change:

@@ -467,7 +470,7 @@ static CMPIStatus get_device(const CMPIO
                                    conn,
                                    devid,
                                    NAMESPACE(reference),
-                                   type_from_classname(CLASSNAME(reference)));
+                                   device_type_from_classname(cn));

the line would wrap.  By consolidating all the CLASSNAME() calls into
a const char * (which is what I should have done in the first place) I
avoided wrapping that line :)

-- 
Dan Smith
IBM Linux Technology Center
Open Hypervisor Team
email: danms at us.ibm.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvirt-cim/attachments/20071102/a9bbe3ca/attachment.sig>


More information about the Libvirt-cim mailing list