[Libvirt-cim] [PATCH] Make ResourcePoolConfigurationService return errors when appropriate

Jay Gagnon grendel at linux.vnet.ibm.com
Mon Nov 5 20:17:04 UTC 2007


Dan Smith wrote:
> # HG changeset patch
> # User Dan Smith <danms at us.ibm.com>
> # Date 1194283579 28800
> # Node ID 0ae96e2255c9d6b095b3cbdcbb247621a8abd91a
> # Parent  fa10054ee62b6f5bb7fc3f832464e4d6caf6f274
> Make ResourcePoolConfigurationService return errors when appropriate
> and fix up some other general error-handling around the needed changes.
>
> This includes a use of the (now controversial) cu_compare_ref() function,
> so I won't commit this until we come to a decision about it, but the
> act of checking the reference is something we need to do here, no matter
> how it shakes out.
>
> Signed-off-by: Dan Smith <danms at us.ibm.com>
>
>
>   
I'll stay out of the cu_compare_ref() discussion for now, but pretending
for the moment that it ends up meeting approval one way or another, this
is a fine use of it.  +1


-- 

-Jay




More information about the Libvirt-cim mailing list