[Libvirt-cim] [PATCH 3 of 5] Remove ":disk" from target device in disk XML

Dan Smith danms at us.ibm.com
Wed Nov 7 16:02:28 UTC 2007


# HG changeset patch
# User Dan Smith <danms at us.ibm.com>
# Date 1194454625 28800
# Node ID 03b92d27d21ea95b552642326fb4c357e643f989
# Parent  e7bab3523bd443fe7aaeaf30a7cc97bb312e988d
Remove ":disk" from target device in disk XML
as it doesn't seem to be necessary for regular disk devices, and
it causes virDetachDevice() to fail.

Signed-off-by: Dan Smith <danms at us.ibm.com>

diff -r e7bab3523bd4 -r 03b92d27d21e libxkutil/xmlgen.c
--- a/libxkutil/xmlgen.c	Wed Nov 07 08:56:58 2007 -0800
+++ b/libxkutil/xmlgen.c	Wed Nov 07 08:57:05 2007 -0800
@@ -103,7 +103,7 @@ static char *disk_block_xml(const char *
                        "<disk type='block' device='disk'>\n"
                        "  <driver name='phy'/>\n"
                        "  <source dev='%s'/>\n"
-                       "  <target dev='%s:disk'/>\n"
+                       "  <target dev='%s'/>\n"
                        "</disk>\n",
                        path,
                        vdev);
@@ -122,7 +122,7 @@ static char *disk_file_xml(const char *p
                        "<disk type='file' device='disk'>\n"
                        "  <driver name='tap' type='aio'/>\n"
                        "  <source file='%s'/>\n"
-                       "  <target dev='%s:disk'/>\n"
+                       "  <target dev='%s'/>\n"
                        "</disk>\n",
                        path,
                        vdev);




More information about the Libvirt-cim mailing list