[Libvirt-cim] [PATCH 5 of 6] Add processor support to SettingsDefineCapabilities

[Dan Smith]

JG> +        cpuinfo = fopen("/proc/cpuinfo", "r");

This should come from virNodeInfo.  Also, it would be good to go ahead
and split out the "how many vcpus is the max for xen?" behavior into a
separate function, because it's possible that other platforms will be
able to overcommit vcpus.  This might be a good place to start making
it clear that the behavior is platform-dependent.  I think it's okay
to always take the Xen default for the time being, but while you're
reworking this, you might as well split it out too.

-- 
Dan Smith
IBM Linux Technology Center
Open Hypervisor Team
email: danms at us.ibm.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvirt-cim/attachments/20071108/4e3f84f1/attachment.sig>