[Libvirt-cim] [PATCH 6 of 6] Add another relationship to ElementCapabilities, the ResourcePool-AllocationCapabilities connection. Only supports the pool_to_alloc direction, because it is the only one that's terribly interesting, but the other direction will need to be added at some point

[Dan Smith]

KR> Just a nit-picky thing here... why not call the AllocCapabilities
KR> function that setups the instance?  I think using the same
KR> InstanceID for the AllocCapa as the pool might not always return
KR> the correct instance because AllocCapa uses <pool type>/0 as the
KR> InstanceID.  But something like the NetworkingPool returns
KR> "NetworkPool/xenbr0".  So you'll be creating an instance with
KR> "NetworkPool/xenbr0" as the InstanceID, which would conflict with
KR> what EnumInstances from AllocCapa would return.

I think AllocationCapabilities needs to change here.  It think using
the InstanceID from the pool makes the most sense.  I'm not sure what
the existing AllocationCapabilities stuff intended, but I'm assuming
it will need to change to match this new stuff.  Perhaps it was a
hold-over from the days of one-pool-per-resource-type?

Good catch, by the way :)

-- 
Dan Smith
IBM Linux Technology Center
Open Hypervisor Team
email: danms at us.ibm.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvirt-cim/attachments/20071108/5d1efc11/attachment.sig>