[Libvirt-cim] [PATCH] Fix AllocationCapabilities to make EnumInstances and EnumInstanceNames work

Jay Gagnon grendel at linux.vnet.ibm.com
Tue Nov 20 14:59:07 UTC 2007


Kaitlin Rupert wrote:
> Jay Gagnon wrote:
>> +        conn = lv_connect(_BROKER, &s);
>> +        if (conn == NULL)
>> +                goto out;
>>
>>   
> Just a minor suggestion.. should lv_connect() be
> connect_by_classname() instead?  =)
>
Honestly, I wasn't really sure on if there had been a resolution on that
front yet, and it was working fine for testing purposes with lv_connect,
so I figured I could always fix it later when the final word came down
on lv_connect versus connect_by_classname.  Have we settled on one yet?

-- 

-Jay




More information about the Libvirt-cim mailing list