[Libvirt-cim] [PATCH 2 of 2] Fix AllocationCapabilities to make EnumInstances and EnumInstanceNames work

Jay Gagnon grendel at linux.vnet.ibm.com
Tue Nov 20 21:25:01 UTC 2007


Kaitlin Rupert wrote:
> Jay Gagnon wrote:
>> +
>> +        conn = connect_by_classname(_BROKER, CLASSNAME(ref), &s);
>> +        if (conn == NULL) {
>> +                cu_statusf(broker, &s,
>> +                           CMPI_RC_ERR_FAILED,
>> +                           "Could not connect to hypervisor");
>> +                goto out;
>> +        }
>>   
> <snip>
>> +
>> + out:
>> +        inst_list_free(&alloc_cap_list);
>> +        inst_list_free(&device_pool_list);
>>          return s;
>>  }
>>
>> @@ -97,8 +192,23 @@ static CMPIStatus GetInstance(CMPIInstan
>>          return return_alloc_cap(reference, results, 0);
>>  }
>>
>>   
> Do you need to close the conn before the function returns?
>
Yes I do, good spot.  I'll resend shortly.

-- 

-Jay




More information about the Libvirt-cim mailing list