[Libvirt-cim] [PATCH 1 of 2] Remove static from get_rasd_instance()

Jay Gagnon grendel at linux.vnet.ibm.com
Wed Nov 21 18:53:43 UTC 2007


Kaitlin Rupert wrote:
> Jay Gagnon wrote:
>>> @@ -264,7 +265,7 @@ static CMPIStatus GetInstance(CMPIInstan
>>>                  goto out;
>>>          }
>>>
>>> -        inst = get_rasd_instance(context, ref, id, type);
>>> +        inst = get_rasd_instance(context, ref, _BROKER, id, type);
>>>       
>> Think you got the wrong broker there.  Should be broker, not _BROKER,
>> right?  Everything else looks fine.  Assuming that _BROKER gets taken
>> care of, it's +1 from me.
>>   
> The way the patch was generated made this piece confusing.  
> get_rasd_instance() is being called from the GetInstance() function in
> Virt_RASD.c.  Anytime a provider calls get_rasd_instance(), it will
> need to pass it's own _BROKER.
>
Ah, I see now.  My bad. :)

-- 

-Jay




More information about the Libvirt-cim mailing list