[Libvirt-cim] [PATCH] More rpm spec changes

[Daniel Veillard]

On Mon, Nov 26, 2007 at 04:54:30PM -0700, Dan Smith wrote:
> - Make dist a dependency of rpm and change the permissions on the spec file
>   before building the rpm
[....]
> - Include COPYING file in the base package
> 
> Signed-off-by: Dan Smith <danms at us.ibm.com>
> 
> diff -r 183df45f2bb6 -r 05f120725e3d Makefile.am
> --- a/Makefile.am	Wed Nov 21 07:01:01 2007 -0800
> +++ b/Makefile.am	Mon Nov 26 16:51:12 2007 -0800
> @@ -47,6 +47,7 @@ clean-local:
>  clean-local:
>  	rm -f $(BUILT_SOURCES) *~
>  
> -rpm: clean
> -	@(unset CDPATH ; $(MAKE) dist && rpmbuild -ta $(distdir).tar.gz)
> +rpm: clean dist
> +	@chmod 0644 libcmpiutil.spec $(distdir).tar.gz
> +	@(unset CDPATH ; rpmbuild -ta $(distdir).tar.gz)

  well the problem  of CDPATH is that 'make dist' tends to break 
if you have a CDPATH (since 'cd' echo the selected directory),
so that change doesn't work. Just add the chmods in the @()

> -%doc doc/doxygen.conf doc/mainpage README
> +%doc doc/doxygen.conf doc/mainpage README COPYING

  GNU autoconf tends to populate COPYING with the GPL licence,
we just need to make sure this doesn't happen in practice ...

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard at redhat.com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/