[Libvirt-cim] [PATCH] Convert CMSetStatusWithChars calls to cu_statusf, clean up

Jay Gagnon grendel at linux.vnet.ibm.com
Tue Nov 27 22:09:23 UTC 2007


Dan Smith wrote:
> Sweet!
>
> JG> -                CMSetStatusWithChars(broker, &s, CMPI_RC_ERR_FAILED,
> JG> -                                     "Could not get ResourceType.");
> JG> +                cu_statusf(broker, &s, 
> JG> +                           CMPI_RC_ERR_FAILED,
> JG> +                           "Could not get ResourceType.");
>
> I know that these are pre-existing error messages, but could I
> convince you to remove trailing periods from all the error messages?
> Not only are they inconsistent with the rest of the code, but rather
> unconventional, I'd say.
>   

Yup, can do.  I had always gone back and forth on the issue when I typed
stuff, and I guess it shows.  Answering it either way is fine by me.

-- 

-Jay




More information about the Libvirt-cim mailing list