[Libvirt-cim] [PATCH 06 of 18] Fixes to VSMS for libcmpiutil API change
Kaitlin Rupert
kaitlin at linux.vnet.ibm.com
Wed Nov 28 17:41:47 UTC 2007
Dan Smith wrote:
> free(dev->dev.net.type);
> - cu_get_str_prop(inst, "NetworkType", &dev->dev.net.type);
> - if (dev->dev.net.type == NULL)
> - dev->dev.net.type = strdup("bridge");
> + dev->dev.net.type = strdup(val);
> } else if (type == VIRT_DEV_MEM) {
> cu_get_u64_prop(inst, "VirtualQuantity", &dev->dev.mem.size);
> cu_get_u64_prop(inst, "Reservation", &dev->dev.mem.size);
> @@ -215,12 +224,10 @@ static int rasd_to_vdev(CMPIInstance *in
>
I'm not as familiar with the device support as a I should be. =) It
looks like your removing support for the NULL case here. Is returning
the network type of "bridge" in the NULL case no longer valid?
--
Kaitlin Rupert
IBM Linux Technology Center
karupert at us.ibm.com
More information about the Libvirt-cim
mailing list