[Libvirt-cim] [PATCH 2 of 3] Removed error messages that cause wrong error returns

Heidi Eckhart heidieck at linux.vnet.ibm.com
Wed Nov 28 20:53:41 UTC 2007


# HG changeset patch
# User Heidi Eckhart <heidieck at linux.vnet.ibm.com>
# Date 1196283441 -3600
# Node ID 53d512fbf05747b7bca5c189b0d6ab5e7e63f90b
# Parent  85f916da818a0d078d21efbb09df724e9cbf31dc
Removed error messages that cause wrong error returns

The case that no handler was found for a request caused an
error as return. This is wrong as the not-found handler
tells only, that the provider is not responsible for the
given request. In scenarios with a general request causing
the call of several association providers that return
valid instances, the former behavior causes a wrong
result, as the CIMOM would return the error and revoke all
valid results.
Signed-off-by: Heidi Eckhart <heidieck at linux.vnet.ibm.com>

diff -r 85f916da818a -r 53d512fbf057 std_association.c
--- a/std_association.c	Wed Nov 28 21:57:20 2007 +0100
+++ b/std_association.c	Wed Nov 28 21:57:21 2007 +0100
@@ -170,9 +170,6 @@ static CMPIStatus do_assoc(struct std_as
         handler = std_assoc_get_handler(ctx, ref);
         if (handler == NULL) {
                 CU_DEBUG("No handler found.");
-                cu_statusf(ctx->brkr, &s,
-                           CMPI_RC_ERR_FAILED,
-                           "Unable to handle this association");
                 goto out;
         }
 
@@ -269,9 +266,7 @@ static CMPIStatus do_ref(struct std_asso
 
         handler = std_assoc_get_handler(ctx, ref);
         if (handler == NULL) {
-                cu_statusf(ctx->brkr, &s,
-                           CMPI_RC_ERR_FAILED,
-                           "Unable to handle this association");
+                CU_DEBUG("No handler found.");
                 goto out;
         }
 




More information about the Libvirt-cim mailing list