[Libvirt-cim] [PATCH] [TEST][Addition] : Adding 03_refprofile_errs.py tc to verify ReferencedProfile

Dan Smith danms at us.ibm.com
Wed Apr 2 17:29:45 UTC 2008


DK> # HG changeset patch
DK> # User Deepti B. Kalakeri <deeptik at linux.vnet.ibm.com>
DK> # Date 1207118004 -19800
DK> # Node ID 421fe4997e8b298bdbb74280743e60e51226d16d
DK> # Parent  f3e2ef4edbb4ec299aaba8a9a6307e5b777a8712
DK> [TEST][Addition] : Adding 03_refprofile_errs.py tc to verify
          ^^^^^^^^^^

I think the [Addition] tag is superfluous and it results in a total of
*four* such tags for each patch, which I think is a bit
excessive... :)

DK> +        proflist = enumclass.enumerate(server, eval('enumclass.' + reg_classname), key_list, virt)
DK> +        if len(proflist) < 5 :

Same comment as before for this as well.

DK> +    profiles_instid_list = []
DK> +    for profile in proflist:
DK> +        profiles_instid_list.append(profile.InstanceID)

Not that it matters, but the following is a shortcut for something
like this:

  instid_list = [x.InstanceID for x in proflist]

-- 
Dan Smith
IBM Linux Technology Center
Open Hypervisor Team
email: danms at us.ibm.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvirt-cim/attachments/20080402/4c6e18ea/attachment.sig>


More information about the Libvirt-cim mailing list