[Libvirt-cim] [PATCH] [TEST] Adding 05_RAPF_err.py to verify RAPF

[Dan Smith]

DK> +def check_bridge_name(bridgename):
DK> +    bridge_list = live.available_bridges(server)
DK> +    vbr = None 
DK> +    if bridgename in bridge_list:
DK> +        import random
DK> +        vbr = bridgename + str(random.randint(1, 100))
DK> +        if vbr in bridge_list:
DK> +            logger.error('Need to give different bridge name since it already exists')
DK> +            return None
DK> +    else:
DK> +        vbr = bridgename
DK> +    return vbr

I think this would make a lot more sense as:

  def get_unique_bridge():
      bridge = "invalid-bridge"
  
      while bridge not in live.available_bridges():
          bridge += str(random.randint(1,100))
  
      return bridge

DK> +    if virt != 'XenFV':
DK> +        bridge = vsxml.set_vbridge(server)

Can you explain why this special case exists?

-- 
Dan Smith
IBM Linux Technology Center
Open Hypervisor Team
email: danms at us.ibm.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvirt-cim/attachments/20080404/08f0c24c/attachment.sig>