[Libvirt-cim] [PATCH] [TEST] Fix domain created error in RASD.01

[Kaitlin Rupert]

Guo Lian Yun wrote:
> libvirt-cim-bounces at redhat.com wrote on 2008-04-07 23:27:39:
> 
>  > GY> # HG changeset patch
>  > GY> # User Guolian Yun <yunguol at cn.ibm.com>
>  > GY> # Date 1207560373 25200
>  > GY> # Node ID 4578382726b1d2099c9b467a0532052b67af42e9
>  > GY> # Parent  bedc7fc28125f9d6cc21f7a6752b479313f070e5
>  > GY> [TEST] Fix domain created error in RASD.01
>  >
>  > When I run the test suite with this patch applied, I get the following
>  > stack trace for this test (which I didn't get before):
>  >
>  >  RASD - 01_verify_rasd_fields.py: FAIL
>  >  Traceback (most recent call last):
>  >    File "/usr/lib64/python2.5/logging/__init__.py", line 744, in emit
>  >      msg = self.format(record)
>  >    File "/usr/lib64/python2.5/logging/__init__.py", line 630, in format
>  >      return fmt.format(record)
>  >    File "/usr/lib64/python2.5/logging/__init__.py", line 418, in format
>  >      record.message = record.getMessage()
>  >    File "/usr/lib64/python2.5/logging/__init__.py", line 288, in 
> getMessage
>  >      msg = msg % self.args
>  >  TypeError: not enough arguments for format string
>  >
> 
>  This test with the patch pass for me. The TypeError seems to be a common
>  issue, which repeated several times in cimtest running.  I will try to 
> track down.
>  Also, the patch fix the domain created error, maybe you can apply it 
> firstly.
> 

-    global vsxml
+    global cxml

+    global test_disk
+    if options.virt == 'Xen':
+        test_disk = 'xvda'
+    else:
+        test_disk = 'hda'

I think avoiding globals when possible is a good idea.  I realize that 
the test already used a global vsxml, but I think it'd be cleaner to see 
these variables passed in as arguments instead.

-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com