[Libvirt-cim] [PATCH 3 of 3] [TEST] add a tc that uses 'user' as network type, fais now, also keep track of issue

[Zhengang Li]

Guo Lian Yun wrote:

> # HG changeset patch
> # User Guolian Yun <yunguol at cn.ibm.com>
> # Date 1207728133 25200
> # Node ID 9fec39e06a000701e7f6f1393fcfdffc353498c3
> # Parent  ca5633160e1cf78353d7b892a480f6fb5833e028
> [TEST] add a tc that uses 'user' as network type, fais now, also keep track of issue
> 
> Signed-off-by: Guolian Yun <yunguol at cn.ibm.com>
> 
> diff -r ca5633160e1c -r 9fec39e06a00 suites/libvirt-cim/cimtest/NetworkPort/03_user_netport.py
> --- /dev/null	Thu Jan 01 00:00:00 1970 +0000
> +++ b/suites/libvirt-cim/cimtest/NetworkPort/03_user_netport.py	Wed Apr 09 01:02:13 2008 -0700
> @@ -0,0 +1,93 @@
> +#!/usr/bin/python
> +#
> +# Copyright 2008 IBM Corp.
> +#
> +# Authors:
> +#    Guolian Yun <yunguol at cn.ibm.com>
> +#
> +# This library is free software; you can redistribute it and/or
> +# modify it under the terms of the GNU General Public
> +# License as published by the Free Software Foundation; either
> +# version 2.1 of the License, or (at your option) any later version.
> +#
> +# This library is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> +# General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public
> +# License along with this library; if not, write to the Free Software
> +# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307  USA
> +#
> +
> +# This tc is used to verify the properties returned by the CIM_NetworkPort 
> +# class.
> +#                  
> +#                                             Date : 09-04-2008
> +
> +import sys
> +import pywbem
> +from XenKvmLib import const
> +from XenKvmLib import devices
> +from XenKvmLib.vxml import KVMXML
> +from CimTest.Globals import log_param, logger
> +from CimTest.Globals import do_main
> +from CimTest.ReturnCodes import PASS, FAIL
> +
> +sup_types = ['KVM']
> +
> +test_dom = "test_domain"
> +test_mac = "00:11:22:33:44:55"
> +
> + at do_main(sup_types)
> +def main():
> +    options = main.options
> +    log_param()
> +    const.KVM_default_net_type = 'user'
> +    cxml = KVMXML(test_dom, mac = test_mac)
> +    ret = cxml.define(options.ip)
> +    if not ret:
> +        logger.error('Unable to define domain %s' % test_dom)
> +        return FAIL
> +
> +    devid = "%s/%s" % (test_dom, test_mac)
> +    key_list = { 'DeviceID' : devid,
> +                 'CreationClassName' : "KVM_NetworkPort",
> +                 'SystemName' : test_dom,
> +                 'SystemCreationClassName' : "KVM_ComputerSystem"
> +               }
> +    dev = None 
> +
> +    try:
> +        dev = eval('devices.' + "KVM_NetworkPort")(options.ip, key_list)
Because this test case is limited to KVM, how about:
            dev = devices.KVM_NetworkPort(options.ip, key_list)
+1 for the rest of the patch.

> +    except Exception, detail:
> +        logger.error("Exception: %s" % detail)
> +        cxml.undefine(options.ip)
> +        return FAIL
> +
> +    if dev == None:
> +        logger.error("Error retrieving instance for devid %s" % devid)
> +        cxml.undefine(options.ip)
> +        return FAIL
> +
> +    status = PASS
> +    
> +    addrs = dev.NetworkAddresses
> +    if len(addrs) != 1:
> +        logger.error("Too many NetworkAddress entries (%i instead of %i)" % \
> +              (len(addrs), 1))
> +        status = FAIL
> +        
> +    if addrs[0] != test_mac:
> +        logger.error("MAC address reported incorrectly (%s instead of %s)" % \
> +              (addrs[0], test_mac))
> +        status = FAIL
> +
> +    if status == FAIL:
> +        logger.error("Checked interface %s" % test_mac)
> +
> +    cxml.undefine(options.ip)
> +    return status
> +
> +if __name__ == "__main__":
> +    sys.exit(main())
> 
> _______________________________________________
> Libvirt-cim mailing list
> Libvirt-cim at redhat.com
> https://www.redhat.com/mailman/listinfo/libvirt-cim
> 


-- 
- Zhengang