[Libvirt-cim] [PATCH] [TEST] Add -d to duplicate error output to stderr

Kaitlin Rupert kaitlin at linux.vnet.ibm.com
Fri Apr 11 01:38:38 UTC 2008


>>>              def do_try():
>>>                  try:
>>> +                    log_param(options.debug)
>> log_param() is invoked here. It doesn't hurt to leave the invoke in 
>> every test cases. But we don't have to add that in future test cases.
>>
> Excellent - do_try() just gets better in my book.  ;)
> 
> Would like to see some review comments on this patch.  I have no 
> complaints, but I'm interested in hearing whether people think this is 
> useful.
> 
> Thanks!
> 

Ah.. my mistake.. I didn't notice this at first.  Including log_param() 
in both the test case itself and do_try() causes the messages to be 
written to the log twice.

However, I like the idea of calling log_param() once in do_try() and not 
having to worry about calling it in each test case.

-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com




More information about the Libvirt-cim mailing list