[Libvirt-cim] [PATCH 2 of 6] [TEST] update processor id in Processor01~03 to reflect recent provider changes

Kaitlin Rupert kaitlin at linux.vnet.ibm.com
Fri Apr 11 15:40:46 UTC 2008


>          logger.error("Domain not started, we're not able to check vcpu")
>      else:
>          for i in range(0, test_vcpus):

Can you remove the loop here?  We're only testing one processor, no need 
for a loop.  Also,

> -            devid = "%s/%s" % (test_dom, i)
> +            devid = "%s/%s" % (test_dom, "proc")
>              key_list = { 'DeviceID' : devid,
>                           'CreationClassName' : get_typed_class(options.virt, "Processor"),
>                           'SystemName' : test_dom,
> diff -r 16ad6528cd7d -r 1a230184a44b suites/libvirt-cim/cimtest/Processor/02_definesys_get_procs.py
> --- a/suites/libvirt-cim/cimtest/Processor/02_definesys_get_procs.py	Thu Apr 10 18:49:55 2008 -0700
> +++ b/suites/libvirt-cim/cimtest/Processor/02_definesys_get_procs.py	Thu Apr 10 18:52:48 2008 -0700
> @@ -57,7 +57,7 @@ def check_processors(procs):
>                           procs['SystemName'], default_dom)
>              return 1
> 
> -        devid = "%s/%s" % (default_dom, test_vcpus - 1)
> +        devid = "%s/%s" % (default_dom, "proc")
> 
>          if proc['DeviceID'] != devid: 
>              logger.error("DeviceID %s does not match expected %s.", 
> diff -r 16ad6528cd7d -r 1a230184a44b suites/libvirt-cim/cimtest/Processor/03_proc_gi_errs.py
> --- a/suites/libvirt-cim/cimtest/Processor/03_proc_gi_errs.py	Thu Apr 10 18:49:55 2008 -0700
> +++ b/suites/libvirt-cim/cimtest/Processor/03_proc_gi_errs.py	Thu Apr 10 18:52:48 2008 -0700
> @@ -174,7 +174,7 @@ def main():
>      options = main.options
>      log_param()
> 
> -    devid = "%s/%s" % (test_dom, "0")
> +    devid = "%s/%s" % (test_dom, "proc")
>      status = PASS
> 

-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com




More information about the Libvirt-cim mailing list