[Libvirt-cim] [PATCH] [TEST]Fixing 01_netport.py tc failure
Kaitlin Rupert
kaitlin at linux.vnet.ibm.com
Fri Apr 11 16:47:18 UTC 2008
>> This line and the next end up spanning 80 characters long. The
>> libvirt-cim convention is 80 character lines. Even though we don't
>> follow their convention, I like the idea of shorter line lengths. This
>> helps prevent text from running into the next line - helps with
>> readability. You can do the following without in python (I believe):
>>
>> logger.error("Too many NetworkAddress entries (%i instead of %i)"
>> % (len(addrs), 1))
>>
> I usually run pylint on the tc before submitting them and the pylint
> config file has the max-line-length set to 90.
> Do you want it to be 80 ?
Yes, if you are using a pylint config, then setting a max line length of
80 would be great.
--
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com
More information about the Libvirt-cim
mailing list