[Libvirt-cim] [PATCH] [TEST] #2 Fixing the 04_defineStartVS.py tc failure

Kaitlin Rupert kaitlin at linux.vnet.ibm.com
Fri Apr 11 17:38:29 UTC 2008


> +    # Success: VS is in Enabled State after Define and Start 

Normally, comments are indented to match the line they precede.  So, in 
this case, You'd want:

     # Success: VS is in Enabled State after Define and Start
     if enabState == 2:

Instead of:

# Success: VS is in Enabled State after Define and Start
     if enabState == 2:

However, I've checked this in since it's minor.

Also, I noticed another issue in this test not related to your patch. 
The exception block returns without destroying/undefining the guest. 
Could you write a fix for this?
-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com




More information about the Libvirt-cim mailing list