[Libvirt-cim] [PATCH] [TEST] Add cim_destroy to VirtCIM class

Kaitlin Rupert kaitlin at linux.vnet.ibm.com
Tue Apr 22 14:37:43 UTC 2008


> +    def cim_destroy(self, ip):
> +        service = vsms.get_vsms_class(self.virt)(ip)
> +        cs_cn = get_typed_class(self.virt, 'ComputerSystem')
> +        target = pywbem.cim_obj.CIMInstanceName(cs_cn, keybindings = {
> +                                                        'Name': self.domain_name,
> +                                                        'CreationClassName': cs_cn})

Sorry to be nitpicky - can you set the keybindings on a separate line? 
As it is now, the arguments for CIMInstanceName() are wrapping an 80 
character line.

Otherwise, this looks good!

Thanks!

-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com




More information about the Libvirt-cim mailing list