[Libvirt-cim] [PATCH 2 of 2] Add the HostSystem-to-AC link with EC

[Dan Smith]

>> @@ -260,8 +267,32 @@ static CMPIStatus alloc_to_pool(const CM

KR> Can you add a comment here that this function handles

KR> AC --> HS
KR> AC --> pool

KR> The function name is confusing (or confused me at least =)

I think changing the name is a good idea too.

KR> It looks like the Characteristics value gets set even for the AC ->
KR> Pool case.  Is this expected?

Technically, the ElementCapabilities association reference object has
that field, and it is to be set to 2 if the association is to be
interpreted as the "default" case.  So, I would say: "yes" :)

If others have a differing opinion, I'd certainly be open to
discussion.

-- 
Dan Smith
IBM Linux Technology Center
Open Hypervisor Team
email: danms at us.ibm.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvirt-cim/attachments/20080424/fd889e3e/attachment.sig>