[Libvirt-cim] [PATCH] [RFC] ProcessorRASD, the class that won't go away

[Jay Gagnon]

Dan Smith wrote:
>
> I don't think you need proc_found.
>   
You're right.  That was silly of me.
> JG> +
> JG> +                if (!instance)
> JG> +                        return false;
> JG> +                
> JG> +                device_set_devid(instance, dev, dom);
> JG> +                device_set_systemname(instance, dom);
> JG> +                inst_list_add(list, instance);
> JG> +        }
> JG> +
> JG> +        if (proc_count) {
>
> This should be:
>
>   if (proc_count > 0) {
>   
Fair enough.
> JG> +                ret = vcpu_instances(broker,
> JG> +                                     dom,
> JG> +                                     ns,
> JG> +                                     proc_count,
> JG> +                                     list);
> JG> +        }
> JG> +
> JG> +        return true;
> JG>  }
>
> Also, a quick comment in here about why the processor case is so
> strange would be good.  We know why because we've been over it too
> many times, but for future generations, this might be a bit hard to
> figure out :)
>
>   
Can do.  I'll try my best to not make it sound too pathetic. :)


-- 

-Jay