[Libvirt-cim] [PATCH] [TEST] Add revision branch to RASD.01 & 02

[Kaitlin Rupert]

zli at linux.vnet.ibm.com wrote:
> # HG changeset patch
> # User Zhengang Li <lizg at cn.ibm.com>
> # Date 1209373236 -28800
> # Node ID 5ed6cd841f7b65eeea4af7af845c4ebfc2da4cf1
> # Parent  22ed2c7c77e8ff3d96b40f1e0db2a931b5a7c37e
> [TEST] Add revision branch to RASD.01 & 02
> 
> - Added prev & mrev for 'proc' vs. '0', 'KiloBytes' vs. 'MegaBytes' issue.
> - Updated style format.
> - Added commonly used class name in XenKvmLib.rasd
> 
> Signed-off-by: Zhengang Li <lizg at cn.ibm.com>
> 
> diff -r 22ed2c7c77e8 -r 5ed6cd841f7b suites/libvirt-cim/cimtest/RASD/01_verify_rasd_fields.py
> --- a/suites/libvirt-cim/cimtest/RASD/01_verify_rasd_fields.py	Fri Apr 25 03:20:54 2008 -0700
> +++ b/suites/libvirt-cim/cimtest/RASD/01_verify_rasd_fields.py	Mon Apr 28 17:00:36 2008 +0800
> @@ -47,18 +47,14 @@
> 

> 
>  def init_list(xml, disk, virt="Xen"):
>      """
>          Creating the lists that will be used for comparisons.
>      """
>      procrasd = {
> -                 "InstanceID" : '%s/%s' %(test_dom, "proc"),\
> -                 "ResourceType" : 3,\
> -                 "CreationClassName": get_typed_class(virt, 'ProcResourceAllocationSettingData')
> -                }
> -
> +            "InstanceID" : '%s/%s' % (test_dom,
> +                CIM_REV < prev and "0" or "proc"),
> +            "ResourceType" : 3,


Embedding the if in the proc initialization might lead to confusion (as 
it's not very obvious what's happening here).

I'd recommend using the current provider value in the initialization, 
and then checking the REV and setting the value appropriately.


-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com