[Libvirt-cim] [PATCH] [TEST] updating 03_reverse_errs.py, 04_forward_errs.py

Kaitlin Rupert kaitlin at linux.vnet.ibm.com
Tue Apr 29 19:52:08 UTC 2008


Deepti B. Kalakeri wrote:
> # HG changeset patch
> # User Deepti B. Kalakeri <deeptik at linux.vnet.ibm.com>
> # Date 1209473865 25200
> # Node ID 5bcadaf4ab9957800fce7a564ef4f13851fcf5c8
> # Parent  2b83c1992dfc44573ba0c00729e36311355807ad
> [TEST] updating 03_reverse_errs.py, 04_forward_errs.py
> 
> 1) To use lib fn conf_file(), cleanup_restore() and create_diskpool_file()
> 2) Addressed Indentation.
> 3) Tested on latest source for Xen, XenFV, KVM.
> 4) Need to test with binary rpm on F9 and include the revision string for 04_forward_errs.py.
> 
> Signed-off-by: Deepti B. Kalakeri <deeptik at linux.vnet.ibm.com>
> 

> diff -r 2b83c1992dfc -r 5bcadaf4ab99 suites/libvirt-cim/cimtest/ElementAllocatedFromPool/04_forward_errs.py
> --- a/suites/libvirt-cim/cimtest/ElementAllocatedFromPool/04_forward_errs.py	Sun Apr 27 19:22:03 2008 -0700
> +++ b/suites/libvirt-cim/cimtest/ElementAllocatedFromPool/04_forward_errs.py	Tue Apr 29 05:57:45 2008 -0700
> @@ -29,8 +29,6 @@

> -
> +        print "test_keys", keys
>          if test_vals['cn'] != "valid":

>                  status = FAIL
> +        print "assos", assoc_info
>          if len(assoc_info) != 0:

Can you remove these prints?

> -    return try_assoc(conn, exp_ret, test_dom_invalid, test_keys, \
> -                                                test_vals, log_msg)
> +    return try_assoc(conn, exp_ret, test_dom_invalid, test_keys, test_vals, 
> +                                                                   log_msg)

Odd indention here..

Otherwise, looks good.  Thanks!

-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com




More information about the Libvirt-cim mailing list