[Libvirt-cim] [PATCH] [TEST] Making use of the lib fn conf_file(), cleanup_restore() and create_diskpool_file()

[Kaitlin Rupert]

Deepti B Kalakeri wrote:
> 
> 
> Kaitlin Rupert wrote:
>>> diff -r 0123ff5809dc -r 70e13e2a2abf 
>>> suites/libvirt-cim/cimtest/ElementAllocatedFromPool/04_forward_errs.py

> The Error messages that is being returned when an 
> InvalidCreationClassname is passed is different for pegasus and sfcb.
> On *F9 with sfcb and latest KVM provider* the 04_forward_errs.py tc 
> passes with the error message *"One or more parameter values passed to 
> the method were invalid",
> *while on *F9 or RHEL **with pegasus with the latest source* the 
> 04_forward_errs.py tc passes with the error message* 
> "*CIM_ERR_INVALID_PARAMETER".

This is a good catch.  You're correct - this is coming from the CIMOM. 
In order to know which provider to call, the CIMOM looks up which 
provider the class is registered to.  In this case, it doesn't recognize 
the class and fails.

Both return CIM_ERR_INVALID_PARAMETER.which is an error message we don't 
return currently.  This is one of the more descriptive CMPI return codes 
  (unlike CIM_ERR_FAILED, which could be just about anything).

I'd suggest ignoring the return message in this case.  I think it's 
fairly safe to rely on the return code.

Thoughts?

-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com