[Libvirt-cim] [PATCH] [TEST] Adding KVM and XenFV support to 41_cs_to_settingdefinestate.py

Kaitlin Rupert kaitlin at linux.vnet.ibm.com
Mon Aug 11 18:19:45 UTC 2008


Just a minor comment..

Can all of these comments be changed so that they are hypervisor 
independent?  I think removing the Xen_ prefix is good enough.

Otherwise, this patch looks good.

Thanks!

> +
> +        # Expect the Xen_SystemDevice to return 4 logical device records.


> +
> +        # Get the rasd values that will be used to compare with the Xen_SettingsDefineState


> +            # we expect only one RASD record to be returned for each device that is used to 
> +            # query with the Xen_SettingsDefineState association.


> +    # We expect that Xen_VirtualSystemSettingDataComponent returns only one 
> +    # Xen_VirtualSystemSettingData object when queried with disk, processor,
> +    # network and memory rasd's and all of them return the same output.


> +
> +    # Get the vssd values which will be used for verifying the 
> +    # Xen_VirtualSystemSettingData output from the 
> +    # Xen_VirtualSystemSettingDataComponent results.

> +    # Since the Xen_VirtualSystemSettingDataComponent returns similar 
> +    # output when queried with every RASD, we are taking the output of 
> +    # the last associtaion query as inputs for 
> +    # querying Xen_SettingsDefineState.


> +    # verify the results of Xen_SettingsDefineState with the cs_values list that was 
> +    # built using the output of the enumeration on Xen_ComputerSystem.

-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com




More information about the Libvirt-cim mailing list