[Libvirt-cim] [PATCH] Remove hardcoded Xen prefix from VSMigrationService

[Kaitlin Rupert]

> KR>          CMPIInstance *prev_inst = NULL;
> KR> +        const char *pfx = NULL;
> 
> KR> +
> KR> +        pfx = pfx_from_conn(job->conn);
> 
> I think you leak 'pfx'.

pfx is const.

> 
> KR> @@ -816,15 +808,20 @@
> KR>                                      CMPIStatus *s)
> KR>  {
> KR>          CMPIObjectPath *ref = NULL;
> KR> +        char *type;
> KR> +        
> KR> +        type = get_typed_class(job->ref_cn, "MigrationJob");
> KR>          ref = CMNewObjectPath(_BROKER,
> job-> ref_ns,
> KR> -                              "Virt_MigrationJob",
> KR> +                              type,
> KR>                                s);
> KR> -        if (s->rc != CMPI_RC_OK) {
> KR> +        if (s->rc != CMPI_RC_OK) { 
> 
> The only change to this line is the addition of some trailing
> whitespace.

Oops, missed that when I previewed the patch.

> 
> KR>                  CU_DEBUG("Failed to create job ref for update");
> KR>                  goto out;
> KR>          }
> KR> +
> KR> +        free(type);
> 
> It looks like you leak 'type' if you take the "goto out" in the context
> above.  There may be other places too.

Yikes - yep will resent with this and the above fixed.  Thanks!
-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com