[Libvirt-cim] [PATCH] Make xmlgen.c use libxml2 instead of hacking it out manually

Daniel Veillard veillard at redhat.com
Wed Dec 3 13:48:11 UTC 2008


On Tue, Dec 02, 2008 at 10:31:52AM -0800, Dan Smith wrote:
> DV>    - http://xmlsoft.org/html/libxml-xmlsave.html#xmlSaveTree
> 
> The documentation says that function is not yet implemented, and it
> appears to be correct :)

  well it just misses the number of bytes output, which I guess you can
ignore just fine :-)
  Unless you have a very old libxml2 which would not export
xmlSaveTree, but that sounds unlikely.

> Any reason not to use xmlSaveDoc() here as well?

  IIRC you have a root node called <tmp> and what you really want to
to is serialize the subtree under tmp, so xmlSaveTree() sounds the
right API to use in the first case.
  Also note that xmlSaveDoc has the same defect as xmlSaveTree(),
but that's not a problem (for example you can get the lenght from the
buffer directly.

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel at veillard.com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/




More information about the Libvirt-cim mailing list