[Libvirt-cim] [PATCH 1 of 3] Added association ServiceAccessBySAP (ConsoleRedirectionService <-> KVMRedirectionSAP)

Kaitlin Rupert kaitlin at linux.vnet.ibm.com
Wed Dec 3 22:13:49 UTC 2008


Richard Maciel wrote:
> # HG changeset patch
> # User Richard Maciel <richardm at br.ibm.com>
> # Date 1228337520 7200
> # Node ID 63fa1c7aece56430f1b2b15376dcdf8a114e26d2
> # Parent  ae687011f6def5df176e5b9b553b93e9f907b7d6
> Added association ServiceAccessBySAP (ConsoleRedirectionService <-> KVMRedirectionSAP)
> 
> * CHanged function return_console_sap in the Virt_KVMRedirectionSAP.c so it
> is responsible for returning a CMPIResult type containing the redirection saps
> 
> * Created new function enum_console_sap in Virt_KVMRedirectionSAP.c to return a
> list containg the redirection saps. This new function only takes three arguments:
> the reference to the broker, the reference and a return argument that represent
> the list of redirection saps
> 
> Signed-off by: Richard Maciel <richardm at br.ibm.com>
> 
> diff -r ae687011f6de -r 63fa1c7aece5 src/Virt_KVMRedirectionSAP.c

> +
> +CMPIStatus enum_console_sap(const CMPIBroker *broker,
> +                            const CMPIObjectPath *ref,
> +                            struct inst_list *list)
> +{

You'll also need to modify get_vnc_sessions() to take a broker, 
otherwise you'll potentially seg fault.

Sorry, I didn't catch this in my previous review.

-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com




More information about the Libvirt-cim mailing list