[Libvirt-cim] [PATCH 2 of 2] RPCC: getInstance does not take care of client given object path

Heidi Eckhart heidieck at linux.vnet.ibm.com
Fri Feb 1 11:28:40 UTC 2008


# HG changeset patch
# User Heidi Eckhart <heidieck at linux.vnet.ibm.com>
# Date 1201868641 -3600
# Node ID 21fecbdb0f84910eb9a889319db6486882bd7194
# Parent  d4b86a39d55d2208c5f56a6666ccc212ab60a240
RPCC: getInstance does not take care of client given object path

wbemgi 'http://localhost:5988/root/virt:KVM_ResourcePoolConfigurationCapabilities.InstanceID="wrong"'
returns the instance instead of NOT_FOUND.

Signed-off-by: Heidi Eckhart <heidieck at linux.vnet.ibm.com>

diff -r d4b86a39d55d -r 21fecbdb0f84 src/Virt_ResourcePoolConfigurationCapabilities.c
--- a/src/Virt_ResourcePoolConfigurationCapabilities.c	Fri Feb 01 12:31:45 2008 +0100
+++ b/src/Virt_ResourcePoolConfigurationCapabilities.c	Fri Feb 01 13:24:01 2008 +0100
@@ -99,6 +99,12 @@ static CMPIStatus return_rpc_cap(const C
                                    "No such instance");
                 goto out;
         }
+
+        if (getInstance) {
+                s = cu_validate_ref(_BROKER, reference, inst);
+                if (s.rc != CMPI_RC_OK)
+                        goto out;
+        }
         
         if (names_only)
                 cu_return_instance_name(results, inst);




More information about the Libvirt-cim mailing list