[Libvirt-cim] [PATCH 1 of 2] Add calls into VSMigrationService to utilize new MigrationIndication provider

[Kaitlin Rupert]

Jay Gagnon wrote:
> # HG changeset patch
> # User Jay Gagnon <grendel at linux.vnet.ibm.com>
> # Date 1201882409 18000
> # Node ID a17039d1b29cd5275ecd126782bb1757a415a0c0
> # Parent  6d86529bbdce9eb68b26a7fc5339fd66a1f2fdd2
> Add calls into VSMigrationService to utilize new MigrationIndication provider.
> 
>  static void migrate_job_set_state(struct migration_job *job,
>                                    uint16_t state,
>                                    const char *status)
>  {
>          CMPIInstance *inst;
> +        CMPIInstance *prev_inst;
> +        CMPIInstance *ind;
> +        bool rc;
>          CMPIStatus s;
>          CMPIObjectPath *op;
> 
> @@ -297,12 +319,50 @@ static void migrate_job_set_state(struct
>          CMSetProperty(inst, "Status",
>                        (CMPIValue *)status, CMPI_chars);
> 
> +        CU_DEBUG("Creating indication.");
> +        /* Prefix needs to be dynamic */
> +        ind = get_typed_instance(_BROKER,
> +                                 "Xen",
> +                                 "ComputerSystemMigrationIndication",
> +                                 job->ref_ns);
> +        /* Prefix needs to be dynamic */


I'm showing my indication ignorance here..

Would it be possible to get the prefix from the ref in migrate_do?  You 
could then add a prefix value to the migration job struct.  You already 
do something similar with the namespace.

However, I'm not entirely sure the ref has the proper prefix you need.


-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com