[Libvirt-cim] [PATCH] (2) Remove the embedded object parsing pieces from VirtualSystemManagmentService

[Kaitlin Rupert]

Heidi Eckhart wrote:
> Kaitlin Rupert wrote:
>> Heidi Eckhart wrote:
>>> Kaitlin Rupert wrote:
>>>> # HG changeset patch
>>>> # User Kaitlin Rupert <karupert at us.ibm.com>
>>>> # Date 1201801531 28800
>>>> # Node ID e27208a0ac3f69df3f704ecd32fdfdc78b79dc7c
>>>> # Parent  b8d69e734306e618b4efb53e23c17ffdd8bab128
>>>> (2) Remove the embedded object parsing pieces from 
>>>> VirtualSystemManagmentService.
>>>>
>>>> Updates from set 1 to set 2:
>>>>    Removed unsused sys_op from define_system()
>>>>    Removed unused list from update_resource_setting()
>>>>    Changed CMPIArray **out_arr to **ret_arr in rasd_refs_to_insts()
>>>>
>>>>   
>>> Opps, sorry, I'm sure I was not very clear on what I meant with the 
>>> out_arr. I thought something like this might look better in the code 
>>> ... instead of submitting *out_arr submitting a ret_arr (which itself 
>>> becomes the content of *out_arr at the end).
>>
>> Oh, yes - I did misunderstand.  Thanks for the clarification. =)
>>
>> However, I'm not sure what benefit this gives us.  I think I'm missing 
>> something - does this change prevent an error condition of some sort?
> No, absolutely not. Its only for common look and feel of the code. I see 
> a lot of functions, where an incoming "<type> **param" is handled 
> internally as "<type> *_param" which is set as "*param=_param" at the 
> end. So I thought this is some kind of common for the providers. That's 
> all.

Oh, I see.  Sure, I'll send a new patch. =)

-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com