[Libvirt-cim] [PATCH 1 of 4] RPCS: enumerateInstance(Name)s and getInstance with wrong hypervisor segfaults
Dan Smith
danms at us.ibm.com
Mon Feb 4 19:20:54 UTC 2008
HE> +CMPIStatus get_rpcs(const CMPIObjectPath *reference,
HE> + CMPIInstance **_inst,
HE> + const CMPIBroker *broker,
HE> + bool getInstance)
I think the functionality you're building in here is a good thing.
I have a minor issue with the new parameter. The camelCase differs
From the rest of our style. Perhaps something like "is_gi" would be
more appropriate and also convey the message?
--
Dan Smith
IBM Linux Technology Center
Open Hypervisor Team
email: danms at us.ibm.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvirt-cim/attachments/20080204/909af8d6/attachment.sig>
More information about the Libvirt-cim
mailing list