[Libvirt-cim] [PATCH] [CU] Add more meaningful return messages to EO parsing functions

Kaitlin Rupert kaitlin at linux.vnet.ibm.com
Wed Feb 6 16:23:25 UTC 2008


Heidi Eckhart wrote:
> Kaitlin Rupert wrote:
>> # HG changeset patch
>> # User Kaitlin Rupert <karupert at us.ibm.com>
>> # Date 1202251455 28800
>> # Node ID 7cdea1fba87f7aea14d9b4d4543eb3b70d61fe36
>> # Parent  1e5195053c3280f2185b98da10c595835eee6233
>> [CU] Add more meaningful return messages to EO parsing functions.
>>
>> Add error messages so that something more descriptive than the generic 
>> error message is used.
>>
>> Signed-off-by: Kaitlin Rupert <karupert at us.ibm.com>
>>
>> diff -r 1e5195053c32 -r 7cdea1fba87f std_invokemethod.c
>> --- a/std_invokemethod.c    Tue Jan 29 11:43:44 2008 -0800
>> +++ b/std_invokemethod.c    Tue Feb 05 14:44:15 2008 -0800
>> @@ -55,8 +55,9 @@ static int parse_eo_inst_arg(CMPIString          str 
>> = CMGetCharPtr(string_in);
>>
>>          if (str == NULL) {
>> -                CMSetStatus(s, CMPI_RC_ERR_INVALID_PARAMETER);
>> -                CU_DEBUG("Method parameter value is NULL");
>> +                cu_statusf(broker, s,
>> +                           CMPI_RC_ERR_FAILED,
>>   
> The error code should stay CMPI_RC_ERR_INVALID_PARAMETER

Oops, that was careless of me,  Thanks for catching this. =)

-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com




More information about the Libvirt-cim mailing list