[Libvirt-cim] [PATCH] This changes any uses of CMSetStatus() to cu_statusf()

Kaitlin Rupert kaitlin at linux.vnet.ibm.com
Fri Feb 15 00:23:34 UTC 2008


>          virDomainFree(dom);
> @@ -757,7 +762,9 @@ static CMPIStatus state_change(CMPIMetho
> 
>          ret = cu_get_u16_arg(argsin, "RequestedState", &state);
>          if (ret != CMPI_RC_OK) {
> -                CMSetStatus(&s, CMPI_RC_ERR_INVALID_PARAMETER);
> +                cu_statusf(_BROKER, &s,
> +                           CMPI_RC_ERR_FAILED,
> +                           "Invalid RequestedState");

The original RC was CMPI_RC_ERR_INVALID_PARAMETER, but you're setting it 
as CMPI_RC_ERR_FAILED.

Sorry for the late review...

-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com




More information about the Libvirt-cim mailing list