[Libvirt-cim] [PATCH 2 of 3] Add VirtualSystemSnapshotCapabilities

Heidi Eckhart heidieck at linux.vnet.ibm.com
Wed Feb 27 10:03:19 UTC 2008


Dan Smith wrote:
> +++ b/src/Virt_VirtualSystemSnapshotServiceCapabilities.c	Tue Feb 26 11:21:14 2008 -0800
> @@ -0,0 +1,204 @@
> +/*
> + * Copyright IBM Corp. 2007
>   
2008 ;)
> +static CMPIStatus get_vss_cap(const CMPIBroker *broker,
> +                              const CMPIObjectPath *ref,
> +                              CMPIInstance **_inst,
> +                              bool is_get_inst)
>   
As this function is already prepared for external use (e.g. by 
ElementCapabilities), it makes sense to remove the static and also add 
the header file right with this patch set.

Other than that ... looks very good. Thanks for using the updated 
interfaces :).


-- 
Regards

Heidi Eckhart
Software Engineer
IBM Linux Technology Center - Open Hypervisor




More information about the Libvirt-cim mailing list